ep refresher finish chan add close protection

weibocom · Apr 8, 2024 · 3115d01 · 3115d01
1 parent 1f620a4
commit 3115d01
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/lb/weightedEpRefresher.go b/lb/weightedEpRefresher.go
@@ -121,7 +121,17 @@ func refreshDynamicWeight(holders []*WeightedEpHolder, taskTimeout int64) bool {
 	defer close(finishChan)
 	go func() {
 		wg.Wait()
-		finishChan <- struct{}{}
+		// the chan might be closed
+		select {
+		case _, ok := <-finishChan:
+			if !ok {
+				// chan has been closed
+				return
+			}
+		default:
+			finishChan <- struct{}{}
+			return
+		}
 	}()
 	select {
 	case <-timer.C: