Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增Bkdrsubstr hash方法 #493

Closed
wants to merge 2 commits into from
Closed

新增Bkdrsubstr hash方法 #493

wants to merge 2 commits into from

Conversation

parabala
Copy link
Collaborator

No description provided.

let alg_parts: Vec<&str> = alg.split(super::HASHER_NAME_DELIMITER).collect();
debug_assert!(alg_parts.len() == 2);
debug_assert_eq!(alg_parts[0], "bkdrsubstr");
let markerstr = alg_parts[1].as_bytes().to_vec();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

格式确认,上面两个debug_assert改为assert更佳?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改

Copy link
Member

@hustfisher hustfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM!

@parabala
Copy link
Collaborator Author

暂时不上线按字符串分割,先关闭此pr

@parabala parabala closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants