可用区内资源数量监控 #391
Merged
可用区内资源数量监控 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parabala
force-pushed
the
region_resmis_metric2
branch
from
47b025e to
5a04f66
Compare
viciousstar
reviewed
Nov 16, 2023
| @@ -41,6 +49,10 @@ impl<T: ToNumber> MetricData for T { | |||
| fn incr_to_cache(self, id: &Arc<Id>) { | |||
| crate::register_cache(id, self.int()); | |||
| } | |||
| } | ||
|
|
||
| distance::host_region() | ||
| } |
There was a problem hiding this comment.
与distance::host_region()保持一致；distance::host_region()返回string的原因是返回str会报错;
| } else { | ||
| 0 // region功能关闭时，len_region为0，也就是不输出监控数据；可用区从打开到关闭场景，0也要生成监控数据，覆盖已有的同path旧数据 | ||
| }; | ||
| metrics::resource_num_metric( |
There was a problem hiding this comment.
增加的指标数量会不会太多，内存总量有上升吗？指标动态创建会有瞬时的较大内存申请
There was a problem hiding this comment.
从tcp copy环境看没有肉眼可见的增加
| return region.clone(); | ||
| } | ||
|
|
||
| return "cnx".to_string(); |
| }; | ||
|
|
||
| metric += n; | ||
| } |
There was a problem hiding this comment.
没合适的位置；新增一个文件似乎也不值当。有建议的地方吗？
icycrystal4
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
与#383的区别是：#383采用全局变量+lock，只推0；本方案是开启可用区，则可用区内的资源数量都推，按资源/端口维度推监控