修复mc超时时间未配置时被初始化为100ms的问题 #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustfisher
reviewed
Nov 7, 2023
endpoint/src/cacheservice/topo.rs
Outdated
| crate::TO_MC_M.to(ns.timeout_ms_master) | ||
| } else { | ||
| crate::TO_MC_M | ||
| }; |
There was a problem hiding this comment.
root cause 是 to 方法没有增加判断？ 在to()增加check，是不是更佳
hustfisher
reviewed
Nov 8, 2023
endpoint/src/lib.rs
Outdated
| const TO_MC_M: Timeout = Timeout::from_millis(500); | ||
| const TO_MC_S: Timeout = Timeout::from_millis(80); | ||
| const TO_MC_M: Timeout = Timeout::from_millis(100); | ||
| const TO_MC_S: Timeout = Timeout::from_millis(100); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.