Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve punycode deprecation by redirecting imports to userland module #160

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,27 +43,30 @@
];

function surpressWarnings(message, warn) {
if (message.code === "CIRCULAR_DEPENDENCY") return;
warn(message);
if (message.code === "CIRCULAR_DEPENDENCY") return;

Check failure on line 46 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 1 tab but found 2 spaces

Check failure on line 46 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 1 tab but found 2 spaces

Check failure on line 46 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 1 tab but found 2 spaces
warn(message);

Check failure on line 47 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 1 tab but found 2 spaces

Check failure on line 47 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 1 tab but found 2 spaces

Check failure on line 47 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 1 tab but found 2 spaces
}

export default [
{
input: "lib/main.js",
external: [...externals],
output: {
file: "dist/main.cjs",
format: "cjs",
},
onwarn: surpressWarnings,
},
{
input: [...tests],
external: [...externals,...devExternals],
output: {
dir: "test/dist/",
format: "cjs",
},
onwarn: surpressWarnings,
},
];
{

Check failure on line 51 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 1 tab but found 2 spaces

Check failure on line 51 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 1 tab but found 2 spaces

Check failure on line 51 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 1 tab but found 2 spaces
input: "lib/main.js",

Check failure on line 52 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 2 tabs but found 4 spaces

Check failure on line 52 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 2 tabs but found 4 spaces

Check failure on line 52 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 2 tabs but found 4 spaces
external: [...externals],

Check failure on line 53 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 2 tabs but found 4 spaces

Check failure on line 53 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 2 tabs but found 4 spaces

Check failure on line 53 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 2 tabs but found 4 spaces
output: {

Check failure on line 54 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 2 tabs but found 4 spaces

Check failure on line 54 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 2 tabs but found 4 spaces

Check failure on line 54 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 2 tabs but found 4 spaces
file: "dist/main.cjs",

Check failure on line 55 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 3 tabs but found 6 spaces

Check failure on line 55 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 3 tabs but found 6 spaces

Check failure on line 55 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 3 tabs but found 6 spaces
format: "cjs",

Check failure on line 56 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 3 tabs but found 6 spaces

Check failure on line 56 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 3 tabs but found 6 spaces

Check failure on line 56 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 3 tabs but found 6 spaces
paths: {

Check failure on line 57 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 3 tabs but found 6 spaces

Check failure on line 57 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 3 tabs but found 6 spaces

Check failure on line 57 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 3 tabs but found 6 spaces
'punycode': 'punycode/',

Check failure on line 58 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (ubuntu-latest, 20.x)

Expected indentation of 4 tabs but found 8 spaces

Check failure on line 58 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 18.x)

Expected indentation of 4 tabs but found 8 spaces

Check failure on line 58 in rollup.config.js

View workflow job for this annotation

GitHub Actions / test_node (macos-latest, 20.x)

Expected indentation of 4 tabs but found 8 spaces
}
},
onwarn: surpressWarnings,
},
{
input: [...tests],
external: [...externals,...devExternals],
output: {
dir: "test/dist/",
format: "cjs",
},
onwarn: surpressWarnings,
},
];
Loading