Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict type imports and regenerate lockfile #136

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

yayuyokitano
Copy link
Member

Adds requirement for explicitly stating type imports.
This marginally helps improve build speeds, and lays some groundwork for us potentially separating out some code in final build to reduce bundle size (and probably further reduce build speeds).
Also, this rule was erroring until I regenerated the lockfile with some updated deps, so i did that

@yayuyokitano yayuyokitano requested a review from inverse February 1, 2024 13:35
Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yayuyokitano yayuyokitano merged commit 72f2039 into master Feb 8, 2024
3 checks passed
@yayuyokitano yayuyokitano deleted the update branch February 8, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants