-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prefetch, Resource Hints and more Fetch keys #2418
Conversation
Ready for review, with a few specific bits to note:
|
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
…into more-fetch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've re-reviewed and the only thing outstanding now is the link-rel-preload
description (#2418 (comment)). This is very close!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I have one line comment with suggestions for the new preload description, but otherwise this is good. Please merge after you've considered my suggestion.
Co-authored-by: Daniel D. Beck <[email protected]>
Draft, some of these need better homeOk, a tangled web of features here. Easier to discuss in one place since they're interrelated.
Prefetch vs Speculation Rules
Speculation rules is broader. Prefetching is one
purpose
, but there can and will be more (eg prerender).Developer POV seems to more be about "prefetch" than "speculation rules" as a singular thing, so I kept it split out - and that aligns w/ spec as well where it's separate.
Speculation Rules is more modern flexible approach that perhaps should be centered, but unless we're trying to actively shape how developers think about this, we should probably keep Prefetch as a standalone feature.
Resources hints -
together orseparateA bunch of
rel
attribute values on the<link>
tag related to performance, and collectively calledresource hints
in more than a few places, eg https://web.dev/learn/performance/resource-hints.Bunched for now, feedback wanted on whether to group or not.
Update:
modulepreload
is separate feature already and a Caniuse feature so splitting this into separate features.Authorization header removed in cross-origin redirects
I wiggled a bit on whether to put the
authorization_removed_cross_origin
keys all in their features or inFetch
, where that "feature" is specified.Calling it a "feature" is a bit of a stretch
If you're a developer, you want to know whether network access method X supports feature Y
So I left the keys in the implementing network access method.