Skip to content

Commit

Permalink
fix: allow custom lazyCompilation.backend.client (#8934)
Browse files Browse the repository at this point in the history
  • Loading branch information
colinaaa authored Jan 4, 2025
1 parent 6e6b3ce commit f81f1c7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/rspack/src/builtin-plugin/lazy-compilation/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ export default class LazyCompilationPlugin {

apply(compiler: Compiler) {
const backend = getBackend({
...this.backend,
client: require.resolve(
`../hot/lazy-compilation-${
compiler.options.externalsPresets.node ? "node" : "web"
}.js`
)
),
...this.backend
});

new BuiltinLazyCompilationPlugin(
Expand Down

2 comments on commit f81f1c7

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on f81f1c7 Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ecosystem CI detail: Open

suite result
modernjs ❌ failure
rspress ❌ failure
rslib ✅ success
rsbuild ❌ failure
rsdoctor ❌ failure
examples ❌ failure
devserver ✅ success
nuxt ✅ success

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on f81f1c7 Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2025-01-04 99f77c8) Current Change
10000_big_production-mode_disable-minimize + exec 37.8 s ± 547 ms 38.1 s ± 714 ms +0.80 %
10000_development-mode + exec 1.91 s ± 33 ms 1.85 s ± 21 ms -3.27 %
10000_development-mode_hmr + exec 689 ms ± 28 ms 689 ms ± 26 ms +0.07 %
10000_production-mode + exec 2.54 s ± 53 ms 2.49 s ± 26 ms -2.08 %
arco-pro_development-mode + exec 1.75 s ± 72 ms 1.77 s ± 65 ms +1.39 %
arco-pro_development-mode_hmr + exec 377 ms ± 2.9 ms 376 ms ± 1 ms -0.12 %
arco-pro_production-mode + exec 3.63 s ± 83 ms 3.59 s ± 65 ms -1.03 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.66 s ± 84 ms 3.61 s ± 95 ms -1.44 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.59 s ± 75 ms 3.6 s ± 97 ms +0.44 %
threejs_development-mode_10x + exec 1.49 s ± 23 ms 1.49 s ± 14 ms -0.17 %
threejs_development-mode_10x_hmr + exec 785 ms ± 36 ms 763 ms ± 8.2 ms -2.89 %
threejs_production-mode_10x + exec 5.33 s ± 44 ms 5.36 s ± 118 ms +0.55 %
10000_big_production-mode_disable-minimize + rss memory 9550 MiB ± 258 MiB 9503 MiB ± 56.4 MiB -0.49 %
10000_development-mode + rss memory 657 MiB ± 17.6 MiB 650 MiB ± 17.5 MiB -1.12 %
10000_development-mode_hmr + rss memory 1320 MiB ± 346 MiB 1316 MiB ± 267 MiB -0.30 %
10000_production-mode + rss memory 619 MiB ± 31.4 MiB 630 MiB ± 21 MiB +1.77 %
arco-pro_development-mode + rss memory 604 MiB ± 32.9 MiB 598 MiB ± 47.3 MiB -0.88 %
arco-pro_development-mode_hmr + rss memory 628 MiB ± 60.4 MiB 651 MiB ± 123 MiB +3.61 %
arco-pro_production-mode + rss memory 746 MiB ± 57.4 MiB 735 MiB ± 66.6 MiB -1.42 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 757 MiB ± 53.3 MiB 768 MiB ± 64.7 MiB +1.53 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 771 MiB ± 46.7 MiB 770 MiB ± 60.8 MiB -0.15 %
threejs_development-mode_10x + rss memory 665 MiB ± 31.9 MiB 628 MiB ± 24.2 MiB -5.57 %
threejs_development-mode_10x_hmr + rss memory 1234 MiB ± 240 MiB 1119 MiB ± 165 MiB -9.39 %
threejs_production-mode_10x + rss memory 958 MiB ± 57.3 MiB 918 MiB ± 48.7 MiB -4.19 %

Please sign in to comment.