Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad docs and dashboard for indexer RED metrics #3892

Merged
merged 3 commits into from
Jul 28, 2023
Merged

ad docs and dashboard for indexer RED metrics #3892

merged 3 commits into from
Jul 28, 2023

Conversation

MohamedMSaeed
Copy link
Contributor

@MohamedMSaeed MohamedMSaeed commented Jul 26, 2023

Docs for
weaveworks/weave-gitops-enterprise#3134

What changed?
Collecting:
Explorer monitoring documentation extended with indexer write metrics

Dashboard:
Added indexer writes panels to explorer grafana dashboard

Why was this change made?
Increase observability for datastore and monitor RED metrics for write operations

How did you validate the change?
Manual test

Release notes
added docs for indexer write metrics

Documentation Changes

Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments.

It would be also great if you could give a screenshot or environment where we see the added panels in action?

website/docs/explorer/operations.mdx Outdated Show resolved Hide resolved
website/docs/explorer/operations.mdx Outdated Show resolved Hide resolved
website/docs/explorer/operations.mdx Outdated Show resolved Hide resolved
@@ -172,7 +172,7 @@
"uid": "P1809F7CD0C75ACF3"
},
"editorMode": "code",
"expr": "sum(rate(http_request_duration_seconds_count{handler=\"/v1/query\"}[1m]))",
"expr": "sum(rate(http_request_duration_seconds_count{handler=\"/v1/query\"}[2m]))",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would be the context or motivation for the 2m change? why this is better?

@enekofb enekofb self-requested a review July 28, 2023 16:50
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed reads and tested the dashboard and can see indexer writes

Screenshot 2023-07-28 at 17 50 37

@enekofb enekofb enabled auto-merge (squash) July 28, 2023 16:51
@enekofb enekofb merged commit 4a289bc into main Jul 28, 2023
33 checks passed
@enekofb enekofb deleted the wge-3003 branch July 28, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants