-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extended flux runtime ui as runtime ui to also include other gitops controllers #3742
Conversation
@@ -48,6 +48,8 @@ extraEnvVars: | |||
# un-comment when running under weave-gitops-enterprise under a subpath e.g /weave-gitops-enterprise | |||
# - name: ROUTE_PREFIX | |||
# value: /weave-gitops-enterprise | |||
- name: WEAVE_GITOPS_FEATURE_GITOPS_RUNTIME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opted-in for internal feedback
controllers https://github.com/weaveworks/weave-gitops-enterprise/tree/main/docs/architecture#kubernetes-controllers Flux is the core component for delivery gitops applications. Flagger is the component within the Flux Ecosystem for providing advance deployment strategies or progressive delivery. Terraform Controller is the controller that provides capabilities to manage terraform infrastructure within WGE. Cluster Controller: provides the capability to integrate Kubernetes clusters for Weave GitOps Enterprise. Cluster Bootstrap Controller: responsible for bootstrapping Kubernetes clusters joining Weave GitOps Enterprise with baseline capabilities like flux. GitopsSet Controller: provides the capability to have a single definition for an application for multiple environments and a fleet of clusters. Pipeline Controller: provides continuous delivery pipelines capabilities for Weave GitOps Enterprise. Policy Agent: controller to enforces rego policies by controlling admission of violating resources. |
97115a3
to
03370ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will rebuild node_modules now, maybe it will fix it. |
Yeah, the same error with a fresh cluster created with the reboot script with nothing else added. |
it should come due to https://github.com/weaveworks/weave-gitops-enterprise/compare/f31ae9c19d0f797bce754075af1a1c3d80195633..97115a319def0284b0ba3b9b6a12832a6b8cfd7b checking and reverting that change |
apologies @opudrovs have pushed the changes that should address it |
Great, rebulding. |
Tested the UI with the flag on and off, I guess I can see two different views and labels. Not sure why there is one more controller displayed in the Runtime UI, but guess it's expected behavior. |
The new controller is the gitops enterprise app which is expected out of the labels. this ticket #3743 is the follow up to add the right labels to the controllers (which is WIP). |
@opudrovs any suggestion on where to look around the menu highlighting issue? |
@enekofb |
super, i look around! |
@enekofb good luck! If this issue is happening in OSS too, I can approve the current PR and we can open a separate issue for nav item highlight. |
Updated to latest main oss 4f785b8 and the error also seems to be fixed |
…ond flux Signed-off-by: Eneko Fernandez <[email protected]> Signed-off-by: Eneko Fernandez <[email protected]>
Signed-off-by: Eneko Fernandez <[email protected]>
Signed-off-by: Eneko Fernandez <[email protected]>
4f785b8
to
c0fe00a
Compare
Co-authored-by: Olga Pudrovska <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #3741
What changed?
WEAVE_GITOPS_FEATURE_GITOPS_RUNTIME
Why was this change made?
How was this change implemented?
How did you validate the change?
We could see some WGE controllers in the UI
Release notes
Documentation Changes
Follow up