feat: automatic datadog instrumentation #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rperryng
approved these changes
Jan 6, 2025
| @@ -166,19 +190,21 @@ GEM | |||
| standard-rails (>= 0.1.0) | |||
|
|
|||
| PLATFORMS | |||
| ruby | |||
| arm64-darwin-23 | |||
| x86_64-linux | |||
There was a problem hiding this comment.
this has given us trouble before, especially upgrading / devs having different darwin versions... imo would prefer to keep it as just ruby (or keep ruby as one of the platforms anyway)? i know including platform-specific variants means builds won't have to compile native extensions but nokogiri is such a common dependency anyway that 99% of the time im sure it's already going to be cached from a previous build, both in CI or local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Really should have pheme processing in APM so we have visibility on failure etc...
What changed