Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OscryptoDownloader on python 3.8 #1677

Merged
merged 1 commit into from
May 18, 2024
Merged

Disable OscryptoDownloader on python 3.8 #1677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions package_control/downloaders/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@
'wget': WgetDownloader
}

# oscrypto can fail badly on Linux in the Sublime Text 3 environment due to
# trying to mix the statically-linked OpenSSL in plugin_host with the OpenSSL
# loaded from the operating system. On Python 3.8 we dynamically link OpenSSL,
# so it just needs to be configured properly, which is handled in
# oscrypto_downloader.py.
if sys.platform != 'linux' or sys.version_info[:2] != (3, 3) or sys.executable != 'python3':
# oscrypto can fail badly
# 1. on Linux in the Sublime Text 3 environment due to trying to mix the
# statically-linked OpenSSL in plugin_host with the OpenSSL loaded from the
# operating system. On Python 3.8 we dynamically link OpenSSL, so it just needs
# to be configured properly, which is handled in oscrypto_downloader.py.
# 2. on MacOS ARM plattform due to whatever reason. Due to maintanance state of
# oscrypto, start fading it out by disabling it on python 3.8 (ST4)
if sys.platform != 'linux' and sys.version_info[:2] == (3, 3):
try:
from .oscrypto_downloader import OscryptoDownloader
DOWNLOADERS['oscrypto'] = OscryptoDownloader
Expand Down