forked from milvus-io/milvus
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster dev 3 #12
Open
wayblink
wants to merge
39
commits into
master
Choose a base branch
from
cluster-dev-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cluster dev 3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayblink
force-pushed
the
cluster-dev-3
branch
10 times, most recently
from
December 26, 2023 13:00
ecbf3a7
to
419d6ac
Compare
related: milvus-io/milvus-proto#233 issue: milvus-io#29593 /kind enhancement Signed-off-by: wayblink <[email protected]>
issue: milvus-io#29292 Signed-off-by: Cai Zhang <[email protected]>
Signed-off-by: sre-ci-robot <[email protected]>
See also milvus-io#27675 `Allocator.Alloc` and `Allocator.AllocOne` might be invoked multiple times if there were multiple blobs set in one sync task. This PR add pre-fetch logic for all blobs and cache logIDs in sync task so that at most only one call of the allocator is needed. --------- Signed-off-by: Congqi Xia <[email protected]>
See also milvus-io#29699 Querycoord panicked when tried to pop from an empty heap. We assume the heap shall not be empty, but in some branch, the candidate is never pushed back. This PR put pop & push in a closure and adds a defer call to push item back. Signed-off-by: Congqi Xia <[email protected]>
This PR defines the new import reader interfaces and implement a binlog reader for import. issue: milvus-io#28521 --------- Signed-off-by: bigsheeper <[email protected]>
This PR add ctx for load index logs Signed-off-by: Wei Liu <[email protected]>
issue: milvus-io#29672 the storage account need privileges of actions `Microsoft.Storage/storageAccounts/blobServices/containers/blobs/*` at least Signed-off-by: PowderLi <[email protected]>
milvus-io#29590) issue: milvus-io#29230 this pr do these things: 1. add gpu brute force; 2. limit gpu index only support l2 / ip; Signed-off-by: cqy123456 <[email protected]>
…28983) related: milvus-io#25324 Search GroupBy function, used to aggregate result entities based on a specific scalar column. several points to mention: 1. Temporarliy, the whole groupby is implemented separated from iterative expr framework **for the first period** 2. In the long term, the groupBy operation will be incorporated into the iterative expr framework:milvus-io#28166 3. This pr includes some unrelated mocked interface regarding alterIndex due to some unworth-to-mention reasons. All these un-associated content will be removed before the final pr is merged. This version of pr is only for review 4. All other related details were commented in the files comparison Signed-off-by: MrPresent-Han <[email protected]>
issue: milvus-io#29453 sync distribution by rpc will also call loadSegment/releaseSegment, which may cause all kinds of concurrent case on same segment, such as concurrent load and release on one segment. This PR add leader_checker which generate load/release task to correct the leader view, instead of calling sync distribution by rpc --------- Signed-off-by: Wei Liu <[email protected]>
due to `clientMaxSendSize` and `serverMaxRecvSize` will limit the rpc request size limit, they should use same config value, and `serverMaxSendSize` and `clientMaxRecvSize` will limit the rpc response size limit, they should use same config value too. This PR fix unexpected rpc msg limit which caused by the wrong usage of misunderstanding rpc config items Signed-off-by: Wei Liu <[email protected]>
related milvus-io#29588 Signed-off-by: lixinguo <[email protected]> Co-authored-by: lixinguo <[email protected]>
relate: milvus-io#29645 Signed-off-by: aoiasd <[email protected]>
Signed-off-by: Sammy Huang <[email protected]>
This PR implements a new json reader for import. issue: milvus-io#28521 --------- Signed-off-by: bigsheeper <[email protected]>
fix milvus-io#29642 Signed-off-by: yah01 <[email protected]>
…io#29713) See also milvus-io#27675 Signed-off-by: Congqi Xia <[email protected]>
Resolves: milvus-io#29736 Signed-off-by: Congqi Xia <[email protected]>
issue: milvus-io#29697 Signed-off-by: Cai Zhang <[email protected]>
This PR implements a Parquet reader for import. issue: milvus-io#28521 --------- Signed-off-by: bigsheeper <[email protected]>
milvus-io#28410 /kind feature Signed-off-by: wayblink <[email protected]>
…#29627) related to : milvus-io#29417 cardinal indexes upload index files in `Serialize` interface, and throw exception when the `Serialize` failed. Signed-off-by: xianliang <[email protected]>
fix: milvus-io#29585 Signed-off-by: longjiquan <[email protected]>
fix: milvus-io#29349 --------- Signed-off-by: longjiquan <[email protected]>
milvus-io#26137 Signed-off-by: luzhang <[email protected]> Co-authored-by: luzhang <[email protected]>
This pr will make milvus load delta logs concurrently, which should decrease the latency of loading a segment. /kind improvement --------- Signed-off-by: longjiquan <[email protected]>
issue: milvus-io#29654 --------- Signed-off-by: longjiquan <[email protected]>
…io#29667) fix: milvus-io#29663 Signed-off-by: Sammy Huang <[email protected]>
wayblink
force-pushed
the
cluster-dev-3
branch
2 times, most recently
from
January 8, 2024 06:15
608949f
to
dbc95c9
Compare
…ilvus-io#29740) See also milvus-io#27349 The segment level label in querynode used `Legacy` before segment level was correctly passed in Load request. Now this attribute is still using legacy so the metrics does not look right. This PR add paramter for `NewSegment` and passes corrent values for each invocation. Signed-off-by: Congqi Xia <[email protected]>
…9747) Once a role is granted to a user, the user should automatically possess the privilege information associated with that role. issue: milvus-io#29710 Signed-off-by: zhenshan.cao <[email protected]>
issue milvus-io#25639 Signed-off-by: xige-16 <[email protected]> Signed-off-by: xige-16 <[email protected]>
this avoids the conflicts while running multiple unit tests Signed-off-by: yah01 <[email protected]>
wayblink
force-pushed
the
cluster-dev-3
branch
from
January 8, 2024 08:42
dbc95c9
to
d99dfef
Compare
See also: milvus-io#29447 --------- Signed-off-by: yangxuan <[email protected]>
This PR implements a new numpy reader for import. issue: milvus-io#28521 --------- Signed-off-by: bigsheeper <[email protected]>
…29771) Resolves: milvus-io#29770 Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: wayblink <[email protected]>
Signed-off-by: wayblink <[email protected]>
Signed-off-by: wayblink <[email protected]>
wayblink
force-pushed
the
cluster-dev-3
branch
from
January 9, 2024 02:22
d99dfef
to
848eb46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.