Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI infrastructure to run UI tests - Issue #24 #25

Merged
merged 22 commits into from
Jul 19, 2022

Conversation

MichaelPesce
Copy link
Collaborator

#24
Replaced previous node.js.yml with main.yml
New file contains workflow for component testing, installing and running the app, and e2e testing

Copy link
Collaborator

@dangunter dangunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I've left a few comments, mostly minor, with some open questions on the Python code that can possibly be streamlined.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
backend/app/internal/flowsheet/flowsheet.py Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
backend/app/routers/flowsheets.py Outdated Show resolved Hide resolved
backend/app/routers/flowsheets.py Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all my questions/feedback has been addressed so this is ready to go!

I've been playing with the CSV export for the comparison data using pandas: it works fine, but I think it'd be better to open a dedicated PR after merging this one to keep things tidier.

@lbianchi-lbl lbianchi-lbl merged commit 4184947 into watertap-org:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants