-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI infrastructure to run UI tests - Issue #24 #25
Conversation
migrated tests data to data folder
…to add-history-option
Add history option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I've left a few comments, mostly minor, with some open questions on the Python code that can possibly be streamlined.
Co-authored-by: Ludovico Bianchi <[email protected]>
Co-authored-by: Ludovico Bianchi <[email protected]>
Co-authored-by: Ludovico Bianchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all my questions/feedback has been addressed so this is ready to go!
I've been playing with the CSV export for the comparison data using pandas: it works fine, but I think it'd be better to open a dedicated PR after merging this one to keep things tidier.
#24
Replaced previous node.js.yml with main.yml
New file contains workflow for component testing, installing and running the app, and e2e testing