Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extended brackets instead of box-drawing characters in log messages #1

Closed
wants to merge 66 commits into from

Conversation

waldyrious
Copy link
Owner

@waldyrious waldyrious commented Nov 10, 2019

(Opening a PR in my fork to test the Travis build.)

This change is to propose using extended brackets instead of box-drawing characters in multi-line log messages. The box-drawing characters were first introduced in JuliaLang#25111.

This change would have two advantages for multi-line log messages:

  • They would become semantically consistent with the single-line log messages (which use the left bracket character, [)
  • They would become more visually consistent with the single-line log messages, since the box drawing characters and have the horizontal section in the middle of the line, rather than at the top and the bottom like [
  • Due to the previous point, the characters would produce a left-flanking box that actually "wraps" the log message, rather than be slightly shorter than the text.

Examples (based on this PR)

Current:

# Characters used:
# - Box Drawings Light Down and Right, U+250C
# - Box Drawings Light Vertical, U+2502
# - Box Drawings Light Up and Right, U+2514

┌ Info: parameters:
│   {UUID} = UUID("1a7ac041-bdf1-4da1-9e3a-91f6f6c88e92")
│   {PKGNAME} = "Foo"
│   {USERNAME} = "John Doe"
│   {USEREMAIL} = "[email protected]"
│   {GHUSER} = "jdoe"
└   {YEAR} = 2019
Confirm (Y)> 
[ Info: copy and substitute

Proposed:

# Characters used:
# - Left Square Bracket Upper Corner, U+23A1
# - Left Square Bracket Extension, U+23A2
# - Left Square Bracket Lower Corner, U+23A3

⎡ Info: parameters:
⎜   {UUID} = UUID("1a7ac041-bdf1-4da1-9e3a-91f6f6c88e92")
⎜   {PKGNAME} = "Foo"
⎜   {USERNAME} = "John Doe"
⎜   {USEREMAIL} = "[email protected]"
⎜   {GHUSER} = "jdoe"
⎣   {YEAR} = 2019
Confirm (Y)> 
[ Info: copy and substitute

smallnamespace and others added 10 commits September 11, 2019 22:22
Note: requires LLVM 7+ to generatic rsqrt intrinsics
Changes testset to avoid compiler heuristics (copyast) that disables inference.
And changes the allocated macro to rely less on inference to elid allocations for the machinary itself.
This lets us scan a datatype slightly easier,
and opens up a future possibility where we don't have a one-to-one
relationship between fields and contained pointers.
@waldyrious
Copy link
Owner Author

An alternative to make the printing of logs more consistent could be to go the other way and replace [ for single-line log messages with a simple hyphen -, or more appropriately, :

# Characters used:
# - Box Drawings Light Down and Right, U+250C
# - Box Drawings Light Vertical, U+2502
# - Box Drawings Light Up and Right, U+2514
# - Box Drawings Light Right, U+2576

┌ Info: parameters:
│   {UUID} = UUID("1a7ac041-bdf1-4da1-9e3a-91f6f6c88e92")
│   {PKGNAME} = "Foo"
│   {USERNAME} = "John Doe"
│   {USEREMAIL} = "[email protected]"
│   {GHUSER} = "jdoe"
└   {YEAR} = 2019
Confirm (Y)> 
╶ Info: copy and substitute

But honestly I prefer the first approach to this one.

dkarrasch and others added 19 commits November 11, 2019 11:05
* get MulAddMul out of the BLAS way, promote alpha/beta coeffs

* fix ambiguity

* simplify promotion, :crossedfingers:

* remove promote_unless_bool, add symmetry check `syrk_wrapper!` (bugfix)

* give BLAS another chance

* extend coefficient promotion to sym(v/m)! and hem(v/m)!

* fix typo
On non-case-sensitive platforms, it is possible for `cd` and `pwd()` to
return values that are different from what `realpath()` of the same
would give back.  Therefore, we must adjust our tests to be more robust
against this variation.

This should hopefully fix some of the testing hangs on Windows
"Julia from `v0.5` forwards natively supports multi-threading"
became
"Julia forwards natively supports multi-threading", where
the "forwards" doesn't make much sense anymore.
Add LIBEXECDIR relative folder constant
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`.
The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions.

Replaces: JuliaLang#33756
Co-Authored-By: Hans-Peter Suter <[email protected]>
Fix `realpath()` assumptions in REPL test suite
vtjnash and others added 28 commits November 15, 2019 11:45
When edit_title_case was implemented, `uppercasefirst` (née `ucfirst`)
and `titlecase` were doing the same transformation on only one word.
But `titlecase` now transforms non-leading letters to lowercase,
which is more expected for the M-c keyboard combo, as it's the
standard readline behavior (I believe).
For consistency with base/gmp.jl and test/mpfr.jl.
…aLang#33742)

* docs: disambiguate what rand((2, 3)) does (fix JuliaLang#33309)

* Update stdlib/Random/src/Random.jl

Co-Authored-By: Matt Bauman <[email protected]>
)

This adds an `iocontext::Dict{Symbol,Any}` field to `LineEditREPL.options`,
which can be initialized with `atreplinit`, and updated
interactively, e.g. `Base.active_repl.options.iocontext[:compact] = true`.

Fixes JuliaLang#20509.
Yanking twice was fooling `setmark` into believing
that `^Space`, the keybinding for `setmark`, had
been pressed twice, leading to activating the region.
So let's make `setmark` behave as a "command" (and
activate the region) only when called directly by
the user, otherwise treat it as a low-level function.
…ring-nothing

Switch Void to Cvoid in finalizer docstring
It's not unusual to have code that simply returns an argument.  When
used in generic code though, that currently might involve copying the
value to a new box. We sometimes define functions like
`identity(nospecialize x) = x` to work around that, (which is preferable
anyways for other reasons), but it's better for codegen to also just be
aware of this pattern.
datatype: reorganize layout calculation code
* correct genmatmul! for empty input matrices

* tests for getmatmul!
…aLang#33889)

Use `cache.julialang.org` to download `busybox.exe` at test time
@waldyrious waldyrious force-pushed the extended-brackets-in-logs branch from 7b14980 to 6c53d82 Compare November 20, 2019 13:09
@waldyrious waldyrious closed this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.