forked from JuliaLang/julia
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use extended brackets instead of box-drawing characters in log messages #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: requires LLVM 7+ to generatic rsqrt intrinsics
Changes testset to avoid compiler heuristics (copyast) that disables inference. And changes the allocated macro to rely less on inference to elid allocations for the machinary itself.
This lets us scan a datatype slightly easier, and opens up a future possibility where we don't have a one-to-one relationship between fields and contained pointers.
An alternative to make the printing of logs more consistent could be to go the other way and replace
But honestly I prefer the first approach to this one. |
* get MulAddMul out of the BLAS way, promote alpha/beta coeffs * fix ambiguity * simplify promotion, :crossedfingers: * remove promote_unless_bool, add symmetry check `syrk_wrapper!` (bugfix) * give BLAS another chance * extend coefficient promotion to sym(v/m)! and hem(v/m)! * fix typo
On non-case-sensitive platforms, it is possible for `cd` and `pwd()` to return values that are different from what `realpath()` of the same would give back. Therefore, we must adjust our tests to be more robust against this variation. This should hopefully fix some of the testing hangs on Windows
"Julia from `v0.5` forwards natively supports multi-threading" became "Julia forwards natively supports multi-threading", where the "forwards" doesn't make much sense anymore.
delete no-op code
Add LIBEXECDIR relative folder constant
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`. The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions. Replaces: JuliaLang#33756 Co-Authored-By: Hans-Peter Suter <[email protected]>
some small gc optimizations
Fix `realpath()` assumptions in REPL test suite
…-sqrt-fast Add sqrt_llvm_fast intrinsic (see JuliaLang#33220)
simplify allocated macro
When edit_title_case was implemented, `uppercasefirst` (née `ucfirst`) and `titlecase` were doing the same transformation on only one word. But `titlecase` now transforms non-leading letters to lowercase, which is more expected for the M-c keyboard combo, as it's the standard readline behavior (I believe).
For consistency with base/gmp.jl and test/mpfr.jl.
…Lang#33749) Bind this shell-like feature to the usual "meta-.".
…aLang#33742) * docs: disambiguate what rand((2, 3)) does (fix JuliaLang#33309) * Update stdlib/Random/src/Random.jl Co-Authored-By: Matt Bauman <[email protected]>
) This adds an `iocontext::Dict{Symbol,Any}` field to `LineEditREPL.options`, which can be initialized with `atreplinit`, and updated interactively, e.g. `Base.active_repl.options.iocontext[:compact] = true`. Fixes JuliaLang#20509.
Yanking twice was fooling `setmark` into believing that `^Space`, the keybinding for `setmark`, had been pressed twice, leading to activating the region. So let's make `setmark` behave as a "command" (and activate the region) only when called directly by the user, otherwise treat it as a low-level function.
…ring-nothing Switch Void to Cvoid in finalizer docstring
It's not unusual to have code that simply returns an argument. When used in generic code though, that currently might involve copying the value to a new box. We sometimes define functions like `identity(nospecialize x) = x` to work around that, (which is preferable anyways for other reasons), but it's better for codegen to also just be aware of this pattern.
datatype: reorganize layout calculation code
* correct genmatmul! for empty input matrices * tests for getmatmul!
…aLang#33889) Use `cache.julialang.org` to download `busybox.exe` at test time
waldyrious
force-pushed
the
extended-brackets-in-logs
branch
from
November 20, 2019 13:09
7b14980
to
6c53d82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Opening a PR in my fork to test the Travis build.)
This change is to propose using extended brackets instead of box-drawing characters in multi-line log messages. The box-drawing characters were first introduced in JuliaLang#25111.
This change would have two advantages for multi-line log messages:
[
)┌
and└
have the horizontal section in the middle of the line, rather than at the top and the bottom like[
Examples (based on this PR)
Current:
Proposed: