Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for ed/css/css-values-5.json #1376

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Nov 2, 2024

Amend syntax of if(), drop value of <if-condition>

Note: This won't be enough for all CI tests to turn green because Turtledove got further updated yesterday to integrate more IDL from Private Aggregation API, leading to new duplicated IDL errors.

Amend syntax of `if()`, drop value of `<if-condition>`
Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both csstree issues have been closed, which will cause that patch to be requested to be dropped; maybe raise and reference a reffy issue to consider a different css syntax parser since it seems we're hitting a wall with csstree here?

@dontcallmedom
Copy link
Member

I completely misread the csstree issues - they were closed because csstree was fixed; do we still need the patches or would an upgrade to csstree suffice?

Link to internal issue for CSSTree update
@tidoust
Copy link
Member Author

tidoust commented Nov 4, 2024

I completely misread the csstree issues - they were closed because csstree was fixed; do we still need the patches or would an upgrade to csstree suffice?

Yes, issues have indeed been super promptly addressed in CSSTree and a new version of CSSTree should be all we need... but that new version does not exist yet (version 3.0.1 released a couple of days ago does not include these updates) so we still need to wait a bit. In the meantime, we still need the patches.

Side note: dependabot currently seems to reject any update of css-tree, and I don't understand why for the time being. Logs say "No update possible for css-tree 2.3.1".

I dropped the links to the issues, and created an internal issue to track the switch and dig into dependabot's logic...

@tidoust tidoust merged commit fcde781 into main Nov 4, 2024
1 check passed
@tidoust tidoust deleted the patch-20241102100310039 branch November 4, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants