Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributors. #63

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Update contributors. #63

merged 1 commit into from
Dec 19, 2024

Conversation

gkellogg
Copy link
Member

No description provided.

@gkellogg gkellogg added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Dec 17, 2024
@pchampin
Copy link
Contributor

@gkellogg after reverting #52 per our resolution today, I rebased this PR so that you can work on it seamlessly.

@gkellogg
Copy link
Member Author

@pchampin We won't be able to merge this after your changes to the baseline. You can just include the contents of /spec/ns/ in your PR to achieve the same thing.

@gkellogg gkellogg marked this pull request as draft December 19, 2024 21:34
@gkellogg gkellogg marked this pull request as ready for review December 19, 2024 21:46
@gkellogg gkellogg merged commit a9d9890 into main Dec 19, 2024
2 checks passed
@gkellogg gkellogg deleted the contributors branch December 19, 2024 21:46
@pchampin
Copy link
Contributor

@pchampin We won't be able to merge this after your changes to the baseline. You can just include the contents of /spec/ns/ in your PR to achieve the same thing.

looks like you were able to merge it afterall, so I assume this comment is moot, right?
In fact, I did rebase this PR precisely to ensure that it could still be merged...

@gkellogg
Copy link
Member Author

looks like you were able to merge it afterall, so I assume this comment is moot, right?
In fact, I did rebase this PR precisely to ensure that it could still be merged...

Yes, our comments passed each other; all merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkellogg @pchampin