-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dir's auto definition #1118
Conversation
I can review this when it's ready (are you still working on it)? |
Thanks @mgiuca... then we should get @aphillips's eye's on it for approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can fix up some other text in this section while we're here.
-
"implying that the value of the localizable members is by default:" -- I don't know how to parse this part of the sentence (it's right before the list of options). Delete it.
-
"the use agent SHOULD" - s/use/user/
-
Replace "When displaying the localizable members to an end-user..." with:
"The user agent SHOULD display the localizable members to the end-user using the [BIDI] algorithm. If the base direction is ltr or rtl, the user agent SHOULD override Rule P3 of [BIDI] ..."
(Remove the ordered list and drop list item 2 entirely - there is no need to explicitly state what happens in the "auto" case since it's covered by Bidi automatically. And we already have non-normative text to explain what happens in this case, above.)
(Also, it shouldn't say "apply Rule P1"; rule P2 is where the first strong character is chosen. But I would advise deleting this sentence entirely.)
SHA: 55e6818 Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes #1079
This change (choose at least one, delete ones that don't apply):
Implementation commitment (delete if not making normative changes):
If change is normative, and it adds or changes a member:
Commit message:
(Fill in. If making normative changes, describe exactly what the behavioral
difference will be.)
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:
Preview | Diff