Fix response packet size #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of the response packet was calculated by checking the length of the receive buffer. The buffer was created with a fixed size of 10240, so that was always the size of the response payload. Now we store the value of bytes read from ReadFromUDP and pass it on to createTestResponse so that we can create a response packet of the same size as the request packet.
UDP timeouts with trigger a blocking channel read to check if the test was done, whereas the intention was to check if the test was done, and if not, move on and start waiting again. That has now been implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the response packet was calculated by checking the length of the receive buffer. The buffer was created with a fixed size of 10240, so that was always the size of the response payload.
Now we store the value of bytes read from ReadFromUDP and pass it on to createTestResponse so that we can create a response packet of the same size as the request packet.