Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sparse binding support #2609

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add sparse binding support #2609

wants to merge 9 commits into from

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Nov 29, 2024 •
edited
Loading

Changelog:

### Breaking changes
Changes to images:
- `ImageMemory::Sparse` no longer has a field for memory requirements, this is now queried directly from the image.

### Additions
- Support for sparse binding.

Closes #2360, closes #537.

@Rua Rua mentioned this pull request Nov 29, 2024
Closed
LDeakin
LDeakin reviewed Nov 30, 2024
View reviewed changes
Copy link
Contributor

@LDeakin LDeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @Rua! I've tested this with sparse partially resident images and it worked great 👍

vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
@Rua Rua marked this pull request as ready for review November 30, 2024 10:11
@Rua
Copy link
Contributor Author

Rua commented Nov 30, 2024

This is ready for review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDeakin LDeakin LDeakin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support sparse binding Feature support for sparse residency multisampled images is not checked
2 participants
@Rua @LDeakin