Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify eJournals as journals #3981

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Classify eJournals as journals #3981

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
309fe2c
Update FormatCalculator.java
cx6ds Oct 4, 2024
9bfa12a
Update FormatCalculator.java
cx6ds Oct 22, 2024
49541aa
Update format_map.properties
cx6ds Oct 22, 2024
f8744fe
Update format_map_level0.properties
cx6ds Oct 24, 2024
f642904
Update format_map_level1.properties
cx6ds Oct 24, 2024
598e029
Update FormatCalculator.java
cx6ds Oct 24, 2024
9204074
Update FormatCalculator.java
cx6ds Nov 12, 2024
f607ca1
Clean up whitespace.
demiankatz Nov 12, 2024
4989f60
Merge branch 'dev' into classify-ejournals-as-journals
demiankatz Nov 12, 2024
3fe09c3
Revise test to match new index contents.
demiankatz Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions import/index_java/src/org/vufind/index/FormatCalculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,14 @@ protected String getFormatFromBibLevel(Record record, char recordType, char bibL
return "Journal";
default: break;
}
} else if (recordType == 'm') {
demiankatz marked this conversation as resolved.
Show resolved Hide resolved
switch (get008Value(marc008, 23)) {
case 'o':
return "eJournal";
default: break;
}
demiankatz marked this conversation as resolved.
Show resolved Hide resolved
}

// Default to serial even if 008 is missing
if (!isConferenceProceeding(record)) {
return "Serial";
Expand Down
1 change: 1 addition & 0 deletions import/translation_maps/format_map.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ DataSet = Data Set
DiscCartridge = Software
Drawing = Photo
eBook = eBook
eJournal = Journal
demiankatz marked this conversation as resolved.
Show resolved Hide resolved
Electronic = Electronic
ElectronicResource = Software
Filmstrip = Video
Expand Down
Loading