Fixed ARIA attributes on record and collection tabs. #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasitiis
changed the title
|
Thanks, @pasitiis. I'll wait to see what @EreMaijala has to say before digging too deeply. @sturkel89, if time permits, do you mind running the test suite on this one and also manually checking whether the record tab behavior seems negatively impacted in any of the themes? |
sturkel89
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
I ran the complete test suite on this branch, and all tests passed!
I then updated config.ini with the full list of themes, and clicked through the record tabs (Holdings, Description, Comments, Similar Items, and Staff View) in each theme for a couple of different records. Everything worked normally!
Please let me know if there's any other functionality I should check with this PR.
EreMaijala
requested changes
Oct 7, 2024
EreMaijala
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where tabs did not work properly when using VoiceOver with Chrome and Firefox (issues with activating a tab using VO + Space Bar and aria-selected being read incorrectly). The changes aim to follow the ARIA Authoring Practices Guide pattern (https://www.w3.org/WAI/ARIA/apg/patterns/tabs/).
Changes were originally made to the BS5 theme and converted to BS3.
Tested with VO on Safari, Chrome, and Firefox, and with JAWS 2024 on Edge and Chrome.
Hopefully I didn't break anything when I converted the theme, and @EreMaijala could check the impact of the bs3-compact changes.