Enable Whoops for most integration tests #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EreMaijala
commented
Oct 1, 2024
EreMaijala
commented
- Also fixes an issue uncovered by this in status-full.phtml.
- Disables Whoops and logging for tests that expect failures.
- Also fixes an issue uncovered by this in status-full.phtml. - Disables Whoops and logging for tests that expect failures.
demiankatz
reviewed
Oct 2, 2024
| @@ -240,7 +240,8 @@ public function testSavedSearchSecurity(): void | |||
| $this->findAndAssertLink($page, 'Log Out')->click(); | |||
|
|
|||
| // Use user A's delete link, but try to execute it as user B: | |||
| [$base, $params] = explode('?', $delete); | |||
| [, $params] = explode('?', $delete); | |||
| $session->setWhoopsDisabled(true); | |||
There was a problem hiding this comment.
Suggested change
| $session->setWhoopsDisabled(true); | |
| $session->setWhoopsDisabled(true); // We expect an error, so let's act like production mode for realistic testing |
demiankatz
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Thanks, @EreMaijala, this looks good to me!
I just thought it might be helpful to add a couple of comments, and I used that as an excuse to try the suggestion feature I mentioned yesterday. Apparently it's not new (at least four years old), but I only just learned about it. It's available as a button through the comment box when you add a comment to one or more lines of code while reviewing.
| @@ -253,6 +254,7 @@ public function testSavedSearchSecurity(): void | |||
| $this->findAndAssertLink($page, 'Log Out')->click(); | |||
|
|
|||
| // Go back in as user A -- see if the saved search still exists. | |||
| $session->setWhoopsDisabled(false); | |||
There was a problem hiding this comment.
Suggested change
| $session->setWhoopsDisabled(false); | |
| $session->setWhoopsDisabled(false); // go back to stricter error handling |
|
@demiankatz Thanks, and nice to see the suggestions in action. The lines were a bit too long, though, so I decided to add the comments above the actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.