Fixed keyboard selection for bootstrap5 #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @ThoWagen! Just asking for a review from @EreMaijala in case he thinks there's a way we can achieve this with the bs3-compat.js instead of having to create a bs5-specific script. |
|
We also might want to consider rebasing this on the release-10.0 branch so we can get this into the next bug fix release. |
EreMaijala
approved these changes
Sep 12, 2024
1 task
ThoWagen
changed the title
demiankatz
requested changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the keyboard selection for bootstrap 5. Previously, the active item is was not highlighted anymore.
Additionally, Firefox gives a warning for the keyboard cookie since it has no SameSite attribute. This is also fixed.