Add check for empty email value in Shibboleth::authenticate() (#3950)

vufind-org · Sep 18, 2024 · 1cd52ed · 1cd52ed
1 parent 027752a
commit 1cd52ed
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/module/VuFind/src/VuFind/Auth/Shibboleth.php b/module/VuFind/src/VuFind/Auth/Shibboleth.php
@@ -210,7 +210,7 @@ public function authenticate($request)
         foreach ($this->attribsToCheck as $attribute) {
             if (isset($shib[$attribute])) {
                 $value = $this->getAttribute($request, $shib[$attribute]);
-                if ($attribute == 'email') {
+                if ($attribute == 'email' && !empty($value)) {
                     $userService->updateUserEmail($user, $value);
                 } elseif (
                     $attribute == 'cat_username' && isset($shib['prefix'])