Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): allow non-default-export client config file #1564

Merged
merged 9 commits into from
May 23, 2024
Merged

feat(core): allow non-default-export client config file #1564

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
428657a
feat: allow clientConfig file to not have default export
Mister-Hope May 20, 2024
d378e34
chore(core): try to avoid using top level await
Mister-Hope May 20, 2024
3617255
test: add config file with no export
Mister-Hope May 21, 2024
7dd7cf0
Merge branch 'main' into client-file
Mister-Hope May 21, 2024
9bb22cf
test: fix test path on windows
Mister-Hope May 21, 2024
940a7b5
test: add test
Mister-Hope May 22, 2024
23f9697
Merge branch 'main' into client-file
Mister-Hope May 22, 2024
a69f4dd
chore: tweaks
Mister-Hope May 22, 2024
a56fa5f
chore: tweaks
meteorlxy May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions e2e/docs/.vuepress/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { viteBundler } from '@vuepress/bundler-vite'
import { webpackBundler } from '@vuepress/bundler-webpack'
import { defineUserConfig } from 'vuepress'
import { path } from 'vuepress/utils'
import { testPlugin } from './plugins/testPlugin.js'
import { e2eTheme } from './theme/node/e2eTheme.js'

const E2E_BASE = (process.env.E2E_BASE ?? '/') as '/' | `/${string}/`
Expand Down Expand Up @@ -80,4 +81,6 @@ export default defineUserConfig({
}
}
},

plugins: [testPlugin],
})
1 change: 1 addition & 0 deletions e2e/docs/.vuepress/plugins/clientConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import './test.css'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check if the styles are applied correctly to the target elements

3 changes: 3 additions & 0 deletions e2e/docs/.vuepress/plugins/test.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
h1 {
font-size: 32px;
}
8 changes: 8 additions & 0 deletions e2e/docs/.vuepress/plugins/testPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { createRequire } from 'node:module'

const require = createRequire(import.meta.url)

export const testPlugin = {
name: 'test-plugin',
clientConfigFile: require.resolve('./clientConfig.js'),
}
Loading