fix(types/runtime-dom): correct boolean attributes type definitions #12736
+59
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HTML, setting a boolean attribute to the string "false" is invalid. Browsers will treat any string value as true.
This issue was introduced by #3776. Based on the description, it was intended to replace only
boolean | 'false' | 'true'
withBooleanish
, but it actually replaced allboolean
types withBooleanish
as well.For reference, here's the relevant React type definitions. You can see that
boolean
andBooleanish
are distinct types.