fix(reactivity): check rawValue exists in target via set.add vuejs#8647 #12393
+32
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
reviewed
Nov 15, 2024
| expect(observedSet.size).toBe(1) | ||
|
|
||
| const observedMap = reactive(new Map()) | ||
| observedMap.set('key', observed) |
There was a problem hiding this comment.
The test case for Map.set here is incorrect because you only modified add without changing set. I think this part of the test would pass even without this PR. Additionally, the observedMap should have an initial value like observedSet
edison1105
reviewed
Nov 15, 2024
| const target = toRaw(this) | ||
| const proto = getProto(target) | ||
| const hadKey = proto.has.call(target, value) | ||
| // 先获取原始值 |
There was a problem hiding this comment.
this comment seems unnecessary
edison1105
added
scope: reactivity
🍰 p2-nice-to-have
edison1105
reviewed
Nov 15, 2024
| const target = toRaw(this) | ||
| const proto = getProto(target) | ||
| const hadKey = proto.has.call(target, value) | ||
| // 先获取原始值 | ||
| const rawValue = |
There was a problem hiding this comment.
Suggested change
| const rawValue = | |
| const valueToAdd = |
The following operation doesn't always return a raw value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8647