Type Tweak for the Files Property
#1265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the flat config in a typechecked ESLint file (with `exactOptionalPropertyTypes: true`), a type error is reported because the generated type for `flat/recommended` is a union, where one element in the union contains `files?: undefined`. `files` can be omitted, but it cannot be explicitly `undefined``. This uses a const assertion so that, in the inferred type, `files` is correctly omitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the flat config in a typechecked ESLint file (with
exactOptionalPropertyTypes: true), a type error is reported because the generated type forflat/recommendedis a union, where one element in the union containsfiles?: undefined. As per ESLint'sConfigtype,filescan be omitted, but it cannot be explicitlyundefined.This uses a const assertion so that, in the inferred type,
filesis correctly omitted (or an array of strings).(https://www.totaltypescript.com/concepts/as-const)