/login update access_time, status #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be re-opened on the |
|
Nevermind, I see this was done mainly as an example. I'm not sure if the default behavior should be to do another disk I/O to change state into active. The other call - to update access time - should likely be added upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon calling /login endpoint update
This is a step for automation that I think many users might appreciate. We are used to put accounts in an inactive status after some time period has passed. When user logs in back into the solution, we want their account to become active again. These little changes are thus helpful and needed for our automation.
Ideally this should be behind some flag, just raising the PR as I got other devs asking to show an example solution.