Skip to content

Commit

Permalink
fix(radio/checkbox): remove unecessary position=relative
Browse files Browse the repository at this point in the history
When these inputs have a relative position, they end up passing above other elements with the same
index, causing inconsistencies on the screen

fix #1839
  • Loading branch information
lafray committed Sep 25, 2024
1 parent 82bb7a9 commit 7a58546
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

[data-sl-checkbox-input] {
flex-shrink: 0;
position: relative;
background: var(--sl-bg-base);
width: var(--sl-checkbox-size);
height: var(--sl-checkbox-size);
Expand Down
2 changes: 0 additions & 2 deletions packages/shoreline/src/themes/sunrise/components/radio.css
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

& > [data-sl-radio-input] {
appearance: none;
position: relative;
border-radius: var(--sl-radius-full);
cursor: pointer;
width: 1.25rem;
Expand Down Expand Up @@ -65,7 +64,6 @@
display: block;
border-radius: var(--sl-radius-full);
background-color: transparent;
position: absolute;
}

&:disabled {
Expand Down

0 comments on commit 7a58546

Please sign in to comment.