Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add to cart prop #173

Merged

Conversation

EmanuelRamos115
Copy link
Contributor

@EmanuelRamos115 EmanuelRamos115 commented Oct 30, 2024

What does this PR do? *

Changes the logic of sending the checkout url via prop to app settings

How to test it? *

change the checkout url route within the admin and check if the app changed it using the add button

https://jwp916--jwpepperdev.myvtex.com/admin/apps/[email protected]/setup/
https://jwp916--jwpepperdev.myvtex.com/quickorder

Copy link

vtex-io-ci-cd bot commented Oct 30, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@EmanuelRamos115
Copy link
Contributor Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Nov 1, 2024

Warnings
⚠️

package.json was changed, but not yarn.lock (vice-versa) [:bulb: are you sure this is right?]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 84, PR deletions = 21

Generated by 🚫 dangerJS against c039493

ataideverton
ataideverton previously approved these changes Nov 6, 2024
@ataideverton ataideverton merged commit f631c13 into vtex-apps:master Nov 7, 2024
18 of 20 checks passed
Copy link

vtex-io-ci-cd bot commented Nov 7, 2024

Your PR has been merged! App is being published. 🚀
Version 3.15.9 → 3.16.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants