Skip to content

Commit

Permalink
fill in some missing LumatoneEventManager callbacks
Browse files Browse the repository at this point in the history
  • Loading branch information
vsicurella committed Aug 11, 2024
1 parent 97f9ca4 commit 70e60c0
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions Source/lumatone_editor_library/device/lumatone_event_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -518,11 +518,25 @@ FirmwareSupport::Error LumatoneEventManager::handleResponse(const juce::MidiMess
case GET_KEYTYPE_CONFIG:
return handleKeyTypeConfigResponse(midiMessage);

case GET_MAX_THRESHOLD:
case GET_MIN_THRESHOLD:
case GET_AFTERTOUCH_MAX:
case GET_KEY_VALIDITY:
// TODO
return FirmwareSupport::Error::noError;

case GET_VELOCITY_CONFIG:
return handleVelocityConfigResponse(midiMessage);

case GET_FADER_CONFIG:
return handleFaderConfigResponse(midiMessage);

case GET_AFTERTOUCH_CONFIG:
return handleAftertouchConfigResponse(midiMessage);

case GET_VELOCITY_INTERVALS:
return handleVelocityIntervalConfigResponse(midiMessage);

case GET_FADER_TYPE_CONFIGURATION:
return handleFaderTypeConfigResponse(midiMessage);

Expand Down Expand Up @@ -562,6 +576,11 @@ FirmwareSupport::Error LumatoneEventManager::handleResponse(const juce::MidiMess
case GET_MACRO_LIGHT_INTENSITY:
return handleGetMacroLightIntensityResponse(midiMessage);

case GET_PITCH_AND_MOD_BOUNDS:
case GET_EXPRESSION_PEDAL_BOUNDS:
// TODO?
return FirmwareSupport::Error::noError;

default:
jassert(sysExData[MSG_STATUS] == LumatoneFirmware::ReturnCode::ACK);
if (midiMessage.getRawDataSize() <= 8)
Expand Down

0 comments on commit 70e60c0

Please sign in to comment.