Skip to content

Commit

Permalink
send velocity intervals request last and check response status
Browse files Browse the repository at this point in the history
  • Loading branch information
vsicurella committed Aug 11, 2024
1 parent a4898fa commit 1c20cbd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Source/lumatone_editor_library/data/application_state.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -656,15 +656,15 @@ bool LumatoneApplicationState::Controller::requestDeviceGlobalSettings()
// Reset state for tracking response progress
*appState.receiveSettingsStatus = FirmwareSupport::ReceiveSettingsStatus(appState.getLumatoneVersion());

// Velocity curve config
appState.controller->sendVelocityIntervalConfigRequest();

// Macro button colours
appState.controller->requestMacroButtonColours();

// General options
appState.controller->getPeripheralChannels();

// Velocity curve config
appState.controller->sendVelocityIntervalConfigRequest();

return true;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,11 @@ FirmwareSupport::Error LumatoneEventManager::handleVelocityIntervalConfigRespons
{
getReceivedSettingsStatus().receivedVelocityIntervalTable = true;
getFirmwareListeners()->call(&LumatoneEditor::FirmwareListener::velocityIntervalConfigReceived, (int*)data);

if (getReceivedSettingsStatus().completed())
{
// todo?
}
};
return handleTableConfigResponse(midiMessage, unpack, callback);
}
Expand Down

0 comments on commit 1c20cbd

Please sign in to comment.