Timoore rollup #1011
Closed
Timoore rollup #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In GraphicsPipelineConfigurator::copyTo(), don't create a BindDescriptorSet command for descriptor sets that contain null buffer or image data, and emit a warning if a descriptor set contains a mix of null values and valid data. The common case with GraphicsPipelineConfigurator is to bind a pipeline and all the necessary descriptor sets at the same time (in the same StateGroup); this commit supports binding some descriptor sets earlier than the pipeline by not rebinding them with some default value.
|
Will close this PR as I have merged this PR as vsgCs_support branch: https://github.com/vsg-dev/VulkanSceneGraph/tree/vsgCs_support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.