Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(signals, with-collection-service): Update key names #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Johanneslueke
Copy link

replace "signals" key with "computed" key to be type compatible wit the latest ngrx release

SignalStoreFeature<{
    state: ... ,
    signals: ... ,    // old name
   methods: ... 
}>
SignalStoreFeature<{
    state: ... ,
    computed: ... ,    // <--!!! new name
   methods: ... 
}>

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

with the latest release of ngrx the withCollectionService method is type incompatible with the the ngrx "signalStore".

Issue Number: N/A

What is the new behavior?

the "withCollectionService" becomes compatible with the "signalStore" method

Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

replace "signals" key with "computed" key to be type compatible wit the latest ngrx release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant