Skip to content

Commit

Permalink
Merge pull request #387 from bastelfreak/typo2
Browse files Browse the repository at this point in the history
Review guideline: Fix broken markdown link
  • Loading branch information
bastelfreak authored Oct 1, 2024
2 parents b1ee71b + d5b1371 commit 934b35b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion _docs/reviewing_pr.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ one of our modules:
### Approving and Merging

* You can merge your own PR if it was approved by a collaborator with merge permissions and CI is green. Don't merge if either one of those conditions are not true
* Modulesync PRs are an exception (a PR based on changes that the msync tool did, NOT PRs on [modulesync_config][ms_docs]). We agreed some time ago that it's ok to merge your own modulesync PR if CI is green, without separate approval. This is okay because changes to [modulesync_config][ms_docs] were [reviewed and tested](ms_guide)
* Modulesync PRs are an exception (a PR based on changes that the msync tool did, NOT PRs on [modulesync_config][ms_docs]). We agreed some time ago that it's ok to merge your own modulesync PR if CI is green, without separate approval. This is okay because changes to [modulesync_config][ms_docs] were [reviewed and tested][ms_guid]
* If your PR is non-trivial or perhaps has only been approved by a work colleague etc, please consider allowing reasonable extra time for other 3rd parties to leave their reviews before merging.
There is no prescribed minimum review period, or definition of 'reasonable time'. Vox Pupuli trusts collaborators to use their own judgement here.
* It's okay to approve code regardless if CI is still running or not. The code won't be merged if CI fails after the PR got approved
Expand Down

0 comments on commit 934b35b

Please sign in to comment.