Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter user / group for ressource archive #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add parameter user / group for ressource archive #454

wants to merge 1 commit into from

Conversation

dhoppe
Copy link
Member

@dhoppe dhoppe commented May 25, 2020

Fixes #448

@bastelfreak
Copy link
Member

rebased the commit

@bastelfreak
Copy link
Member

rebased

@ndelic0
Copy link

ndelic0 commented Aug 24, 2020

Is there any way to push for this PR?

@bastelfreak
Copy link
Member

@ndelic0 I rebased it again.In case the acceptance tests fail again it would be nice if someone could investigate why they fail.

@ikonia
Copy link

ikonia commented Sep 16, 2020

these checks appear to be passing the failing tests are initial connection tests failing on the host running the test ? or are there other tests failing that I can't see ?

I'm happy to work through the failures to get this merged and released as it's a good fix for a frustrating bug.

Copy link

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not extend the existing tests to cover this behaviour change?

@vox-pupuli-tasks
Copy link

Dear @dhoppe, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/opt/prometheus user and group id is 3434. Should be managable.
5 participants