-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try using vagrant #50
base: master
Are you sure you want to change the base?
Conversation
.github/workflows/ci.yml
Outdated
with: | ||
pidfile_workaround: 'false' | ||
beaker_hypervisor: vagrant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be libvirt?
beaker_hypervisor: vagrant | |
beaker_hypervisor: vagrant_libvirt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The Beaker hypervisor is Vagrant. Which hypervisor vagrant then uses is a different beast. ;)
(hypervisors all the way down)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and I won't go down the rabbithole that libvirt can use different backends, besides qemu, but vagrant-libvirt really only knows about qemu)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's surprising, because I have:
$ env | grep BEAKER
BEAKER_HYPERVISOR=vagrant_libvirt
If you can get this working, I think running tests with vagrant VMs instead of docker will help fix tests for https://github.com/voxpupuli/puppet-chrony and https://github.com/voxpupuli/puppet-rsyslog/ and maybe others. |
This PR was mostly a playground for voxpupuli/gha-puppet#49, but yes this can be useful for a couple of modules. |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues