stdlib v9 support, use namespaced stdlib functions #1208
Conversation
metadata.json
Outdated
| @@ -22,7 +22,7 @@ | |||
| }, | |||
| { | |||
| "name": "puppetlabs/stdlib", | |||
| "version_requirement": ">= 4.13.0 < 9.0.0" | |||
| "version_requirement": ">= 4.13.0 < 10.0.0" | |||
There was a problem hiding this comment.
The namespaced version of merge() was added in 04d1f0c5cccb93d0bc928c7623c4b0c0ebda5b6b which require version 9.0.0 of the stdlib module:
| "version_requirement": ">= 4.13.0 < 10.0.0" | |
| "version_requirement": ">= 9.0.0 < 10.0.0" |
|
@smortex any updates on this PR? |
|
Any updates/progress on this? |
manifests/config.pp
Outdated
| @@ -164,7 +164,7 @@ | |||
| # } | |||
|
|
|||
| # Generate Elasticsearch config | |||
| $data = merge( | |||
| $data = stdlib::merge( | |||
There was a problem hiding this comment.
I would really like to release a new version that allow 9.x before we start requiring 9.x
This makes it a bit easier to upgrade without breaking dependencies.
|
@ggabijaa could you please rebase against voxpupuli:master so that it is ready for merge once the current changes on master is released? |
|
Rename PR and squash commits to something like 'Use namespaced stdlib functions'? |
manifests/config.pp
Outdated
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| $init_defaults = { | |||
| 'MAX_OPEN_FILES' => '65535', | |||
| }.merge($elasticsearch::init_defaults) | |||
| }.stdlib::merge($elasticsearch::init_defaults) | |||
There was a problem hiding this comment.
you can add the hashes with +. then you don't need merge and don't need stdlib.
There was a problem hiding this comment.
#1217 and just close this PR?
ggabijaa
changed the title
|
Thanks for your effort on this @ggabijaa. |
Pull Request (PR) description
Added Stdlib v9 support
Added Puppet v8 support
This Pull Request (PR) fixes the following issues
Fixes #1201