Skip to content

Commit

Permalink
remove java 1.8 support
Browse files Browse the repository at this point in the history
  • Loading branch information
SimonHoenscheid committed Aug 23, 2024
1 parent 6395abd commit 7d94fe2
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 23 deletions.
2 changes: 1 addition & 1 deletion manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

# JVM Settings
$javahome = undef,
Enum['openjdk-11', 'oracle-jdk-1.8', 'custom'] $jvm_type = 'openjdk-11',
Enum['openjdk-11', 'custom'] $jvm_type = 'openjdk-11',
$jvm_xms = '256m',
$jvm_xmx = '1024m',
$jvm_permgen = '256m',
Expand Down
4 changes: 2 additions & 2 deletions spec/acceptance/1_default_parameters_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
cleanup => true,
} ->
class { 'confluence':
version => '5.5.6',
jvm_type => 'oracle-jdk-1.8',
version => '8.5.12',
jvm_type => 'openjdk-11',
download_url => fact('download_url'),
javahome => $jh,
}
Expand Down
2 changes: 1 addition & 1 deletion spec/acceptance/2_default_parameters_upgrade_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
} ->
class { 'confluence':
version => '5.7',
jvm_type => 'oracle-jdk-1.8',
jvm_type => 'openjdk-11',
download_url => fact('download_url'),
javahome => $jh,
}
Expand Down
2 changes: 1 addition & 1 deletion spec/acceptance/3_custom_parameters_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
} ->
class { 'confluence':
version => '5.7',
jvm_type => 'oracle-jdk-1.8',
jvm_type => 'openjdk-11',
download_url => fact('download_url'),
javahome => $jh,
tomcat_port => '8091',
Expand Down
16 changes: 0 additions & 16 deletions spec/classes/confluence_config_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -252,22 +252,6 @@
end
end

context 'java 8 specific option' do
let(:params) do
{
version: '7.12.0',
javahome: '/opt/java',
jvm_type: 'oracle-jdk-1.8'
}
end

it do
is_expected.to compile.with_all_deps
is_expected.to contain_file('/opt/confluence/atlassian-confluence-7.12.0/bin/setenv.sh').
with_content(%r{CATALINA_OPTS="-XX:-PrintGCDetails -XX:\+PrintGCDateStamps -XX:-PrintTenuringDistribution \${CATALINA_OPTS}"})
end
end

context 'manage_user set to true' do
let(:params) do
{
Expand Down
2 changes: 0 additions & 2 deletions templates/setenv.sh.erb
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ CATALINA_OPTS="-Xlog:gc+age=debug:file=$LOGBASEABS/logs/gc-`date +%F_%H-%M-%S`.l
<%- end -%>
<%- if scope.lookupvar('confluence::jvm_type') == 'openjdk-11' -%>
CATALINA_OPTS="-XX:+ExplicitGCInvokesConcurrent -XX:+PrintGCDateStamps ${CATALINA_OPTS}"
<%- elsif scope.lookupvar('confluence::jvm_type') == 'oracle-jdk-1.8' -%>
CATALINA_OPTS="-XX:-PrintGCDetails -XX:+PrintGCDateStamps -XX:-PrintTenuringDistribution ${CATALINA_OPTS}"
<%- end -%>
CATALINA_OPTS="-Xloggc:$LOGBASEABS/logs/gc-`date +%F_%H-%M-%S`.log -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=5 -XX:GCLogFileSize=2M ${CATALINA_OPTS}"
CATALINA_OPTS="-XX:G1ReservePercent=20 ${CATALINA_OPTS}"
Expand Down

0 comments on commit 7d94fe2

Please sign in to comment.