-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testconfig.rb : added excluded_dirs
entry to the onceover.yaml file
#190
base: master
Are you sure you want to change the base?
Conversation
franknarf8
commented
Dec 6, 2018
- Adds the ability to ignore additional folders based on an entry in the onceover.yaml file
- Helps reducing the time spent copying left and right
- Adds the ability to ignore additional folders based on an entry in the onceover.yaml file - Helps reducing the time spent copying left and right
I might need some assistance on that one :S Thanks in advance! - Frank |
Hey Frank, I've fixed those tests. Can you please add something to the README.md and I'll approve, this is a good feature. Out of interest what is the use case for this? |
Thanks Dylan, Sorry about closing/opening the PR, I accidentally pressed the wrong button. About the use case, I had performance issues, as I'll add a section in the README.md momentarily Thanks! |
Mmm, looks like the
I would opt for option 1. |
# Conflicts: # lib/onceover/testconfig.rb
…he onceover.yaml config file
Hello again @dylanratcliffe , So I have adapted my changes to the latest code restructuring; but the unit tests are still not passing. I'm not quite sure, I have something to do with it though. Can you have a look? Thanks - Frank |
# Conflicts: # README.md