Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testconfig.rb : added excluded_dirs entry to the onceover.yaml file #190

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

franknarf8
Copy link

  • Adds the ability to ignore additional folders based on an entry in the onceover.yaml file
  • Helps reducing the time spent copying left and right

- Adds the ability to ignore additional folders based on an entry in the onceover.yaml file
- Helps reducing the time spent copying left and right
@franknarf8
Copy link
Author

@dylanratcliffe

I might need some assistance on that one :S
I'm not quite sure what this yumrepo stuff is about, but I'm pretty sure it has nothing to do with this merge request.

Thanks in advance!

- Frank

@dylanratcliffe
Copy link
Collaborator

Hey Frank, I've fixed those tests. Can you please add something to the README.md and I'll approve, this is a good feature. Out of interest what is the use case for this?

@franknarf8 franknarf8 closed this Jan 6, 2019
@franknarf8 franknarf8 reopened this Jan 6, 2019
@franknarf8
Copy link
Author

Thanks Dylan,

Sorry about closing/opening the PR, I accidentally pressed the wrong button.

About the use case, I had performance issues, as onceover was copying way too many files (e.g. .git/, and other unnecessary fat hidden folders)

I'll add a section in the README.md momentarily

Thanks!

@franknarf8
Copy link
Author

Mmm, looks like the deploy_local code was extracted away, making the testconfig properties inaccessible. Should we :

  1. pass the TestConfig object to deploy_local
  2. find a new home to the additional_excluded_dirs list
  3. deserialize the Controlrepo.onceover_yaml property within deploy_local?

I would opt for option 1.

Frank Genois added 2 commits January 14, 2019 17:09
# Conflicts:
#	lib/onceover/testconfig.rb
@franknarf8
Copy link
Author

franknarf8 commented Jan 14, 2019

Hello again @dylanratcliffe ,

So I have adapted my changes to the latest code restructuring; but the unit tests are still not passing. I'm not quite sure, I have something to do with it though. Can you have a look?

Thanks

- Frank

Frank Genois and others added 2 commits February 21, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants