-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNS3 2.2.25 #32737
GNS3 2.2.25 #32737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next time you can force push to a PR instead of opening a new one.
True. I made a new PR because I made a new branch. The old branch had the 2.2.23 version number in it so I wanted to avoid confusion by creating a new branch with the correct name. |
e2f97d9
to
1dc3ded
Compare
I missed something in gns3-gui. Working on a fix now. |
1dc3ded
to
0556abf
Compare
@paper42 can you take another look? I did a bit of refactoring to get tests working instead of skipping them altogether. It involved adding a couple packages but they were pretty straight forward. I also removed python3-sentry package since it was only used for crash reports and apparently isn't included in the upstream packages. |
0556abf
to
a73fc00
Compare
python3-sentry needs to be added to removed-packages like in #32495 GitHub doesn't detect you as the author of the commits, could you add the email you are using in the commits to your GitHub profile? |
a73fc00
to
cc555d4
Compare
Thanks @paper42 |
General
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)