Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNS3 2.2.25 #32737

Merged
merged 5 commits into from
Sep 19, 2021
Merged

GNS3 2.2.25 #32737

merged 5 commits into from
Sep 19, 2021

Conversation

tsndqst
Copy link
Contributor

@tsndqst tsndqst commented Aug 28, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

@tsndqst tsndqst mentioned this pull request Aug 28, 2021
8 tasks
Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time you can force push to a PR instead of opening a new one.

srcpkgs/gns3-server/template Outdated Show resolved Hide resolved
srcpkgs/gns3-server/template Outdated Show resolved Hide resolved
srcpkgs/python3-sentry/template Outdated Show resolved Hide resolved
srcpkgs/gns3-server/patches/requirements.patch Outdated Show resolved Hide resolved
@tsndqst
Copy link
Contributor Author

tsndqst commented Aug 28, 2021

Next time you can force push to a PR instead of opening a new one.

True. I made a new PR because I made a new branch. The old branch had the 2.2.23 version number in it so I wanted to avoid confusion by creating a new branch with the correct name.

@tsndqst tsndqst force-pushed the gns3-2.2.24 branch 2 times, most recently from e2f97d9 to 1dc3ded Compare September 11, 2021 17:58
@tsndqst
Copy link
Contributor Author

tsndqst commented Sep 11, 2021

I missed something in gns3-gui. Working on a fix now.

@tsndqst
Copy link
Contributor Author

tsndqst commented Sep 12, 2021

@paper42 can you take another look? I did a bit of refactoring to get tests working instead of skipping them altogether. It involved adding a couple packages but they were pretty straight forward.

I also removed python3-sentry package since it was only used for crash reports and apparently isn't included in the upstream packages.

@tsndqst tsndqst changed the title GNS3 2.2.24 GNS3 2.2.25 Sep 15, 2021
@paper42
Copy link
Member

paper42 commented Sep 15, 2021

python3-sentry needs to be added to removed-packages like in #32495

GitHub doesn't detect you as the author of the commits, could you add the email you are using in the commits to your GitHub profile?

@tsndqst
Copy link
Contributor Author

tsndqst commented Sep 15, 2021

Thanks @paper42
I'll make a separate PR for removal of python3-sentry once this PR is merged.
I updated my email address in GitHub as well.

@paper42 paper42 merged commit 9609767 into void-linux:master Sep 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2021
@tsndqst tsndqst deleted the gns3-2.2.24 branch August 29, 2022 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants