-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: ydotool-0.2.0 #31237
New package: ydotool-0.2.0 #31237
Conversation
Updating |
The problem is that both of them became static libraries now... I don't see a point to package them anymore. |
I'll leave it to the team to decide if it's fine to use CPM. If they agree, I'm fine with removing |
I fixed the musl build problem, and this package is ready for review! Note that it statically links against dependencies with CPM. It looks like we accept this for other languages like Rust and Go (static linking against external packages), so I guess it's fine here... |
# patches a dependency pulled by CPM, so it must be done after configure | ||
post_configure() { | ||
patch -sl -Np0 -i ${FILESDIR}/iodash-musl.patch 2>/dev/null | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPM shouldn't be allowed to pull in dependencies. You need to manually download the tarball or package the dependency.
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
It seems like the package uses CPM in its CMake config for statically linking
libevdevPlus
andlibuInputPlus
, both are versioned newer than the existing ones in Void, with breaking changes. There's another dependency calledIODash
which doesn't exist in Void yet.Is it OK to simply use CPM? Or should we update the first two and add the last one into Void, then build with those? Pinging @steinex for opinions.
We already have #25341, but it's an older version and apparently have some unfixed problems... So I wish this is a friendly takeover of that PR.
closes #31163
General
Have the results of the proposed changes been tested?