-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IAC-805 Lazy Load of vRO Inventory Items #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
…ces, configurations Signed-off-by: Alexander Kantchev <[email protected]>
…ventory cache Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
akantchev
changed the title
IAC-805 Add Lazy Load for vRO Categories and Hint Actions
IAC-805 Lazy Load of vRO Inventory Items
Jan 18, 2024
…toring Signed-off-by: Alexander Kantchev <[email protected]>
…rder in order not to overload vRO, code refactoring Signed-off-by: Alexander Kantchev <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 54.21% 54.35% +0.13%
==========================================
Files 40 40
Lines 806 804 -2
Branches 117 116 -1
==========================================
Hits 437 437
+ Misses 331 330 -1
+ Partials 38 37 -1 |
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
igormkdd
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order not to overload the vRO with REST requests to the inventory items REST endpoint in the vRO (on heavily loaded environment) a vRO inventory caching feature has been implemented that loads the inventory items lazy and caches during the visual studio session runtime. The vRO data collection is executed in serial order (in order not to overload the vRO with a lot of parallel REST requests).
Checklist
Fixed #XXX -
orClosed #XXX -
prefix to auto-close the issueTesting
Run the plugin against a real vRO environment, the action hinting should be fetched once thus fetching data only once, further REST request will be made until the refresh button is clicked or the IDE is reloaded. The vRO's vco micro service should not get overloaded with REST requests and no request are getting dropped.
Release Notes
Related Issues
#137