[Task IAC-805] Fixed code coverage issues

Signed-off-by: Alexander Kantchev <[email protected]>
vmware · Feb 5, 2024 · 9b5fee7 · 9b5fee7
1 parent eb6090a
commit 9b5fee7
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/packages/node/vro-language-server/src/server/core/HintLookup.ts b/packages/node/vro-language-server/src/server/core/HintLookup.ts
@@ -59,7 +59,7 @@ export class HintLookup implements Disposable {
 
     dispose(): void {
         this.logger.debug("Disposing HintLookup")
-        this.subscriptions.forEach(s => s?.dispose())
+        this.subscriptions.forEach(s => s && s.dispose())
     }
 
     getGlobalActionsPack() {
@@ -167,10 +167,6 @@ export class HintLookup implements Disposable {
         this.load()
     }
 
-    refreshForWorkspace(workspaceFolder: WorkspaceFolder): void {
-        this.load(workspaceFolder)
-    }
-
     private onDidChangeConfiguration(): void {
         this.logger.debug("HintLookup.onDidChangeConfiguration()")
         this.load()
@@ -183,6 +179,10 @@ export class HintLookup implements Disposable {
         }
     }
 
+    refreshForWorkspace(workspaceFolder: WorkspaceFolder): void {
+        this.load(workspaceFolder)
+    }
+
     //
     // Load proto files
     //
@@ -203,15 +203,17 @@ export class HintLookup implements Disposable {
                 )
             }
         }
+
         const configsFile = this.environment.resolveHintFile("configs.pb", workspaceFolder)
         if (configsFile) {
             this.loadProtoInScope([configsFile], workspaceFolder, this.configs, vmw.pscoe.hints.ConfigurationsPack)
         }
 
         if (!workspaceFolder) {
             // plugins aren't located in workspace folder
-            const coreApiFile = this.environment.resolveHintFile("core-api.pb", undefined)
+            const coreApiFile = this.environment.resolveHintFile("core-api.pb")
             const pluginFiles = this.environment.resolvePluginHintFiles()
+
             if (coreApiFile) {
                 pluginFiles.push(coreApiFile)
             }
@@ -237,6 +239,7 @@ export class HintLookup implements Disposable {
                 result.push(hintPack)
             }
         })
+
         if (!scope) {
             target.global = result
         } else {