Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup enhancement #1009

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Jan 16, 2025

This change is trying to use HAPI in cleanup logic, and remove unnecessary NSX API calls if a VPC is already deleted recursively. It also introduces the VPC deletion in parallel.

Test Done:

  1. With a benchmark for 50 VPCs, 5 subnets/ 100 subnet ports / 5 subnet connection binding maps / 1 static routes / 1 vpc IP address allocation / 1 security policy configured per VPC, the new logic takes about 3m to complete the clean up job, while the original logic may take almost 30m to do the same thing.

@wenyingd wenyingd force-pushed the cleanup_enhancement branch from d776fe1 to 2b12a1d Compare January 16, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants