Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Updating cronjob to batchv1 #3288

Closed
wants to merge 1 commit into from
Closed

Updating cronjob to batchv1 #3288

wants to merge 1 commit into from

Conversation

Freydal
Copy link

@Freydal Freydal commented Jun 2, 2022

What this PR does / why we need it: Fixes an issue with cronjobs being loaded as batch/v1beta1 and the backwards conversion from batch/v1 doesn't work.

Which issue(s) this PR fixes

Special notes for your reviewer:

Release note:

Updated CronJob marshaled object from batch/v1beta1 to batch/v1

Signed-off-by: Nick Freyaldenhoven <[email protected]>
@Freydal
Copy link
Author

Freydal commented Jun 28, 2022

These NPM failures look similar to some stuff I was seeing locally while toying around. I think a node wizard may need to address it.

@Aankhen
Copy link

Aankhen commented Jun 29, 2022

Not a wizard, but the problem is the resolutions field for hosted-git-info in package.json. There’s an open npm-force-resolutions issue where people report sporadic failures with a few different syntaxes. rogeriochaves/npm-force-resolutions#56 (comment) suggests migrating to the new, builtin overrides field instead so there’s no need for npm-force-resolutions. In this case, npm ls marks both dns-packet and hosted-git-info as ‘extraneous’, so maybe those two entries could be dropped entirely.

@Freydal
Copy link
Author

Freydal commented Jun 29, 2022

@Aankhen I'll look over this shortly, but I went about it differently.
#3311

@HighWatersDev
Copy link

Hi @Freydal did you have a chance to look into this?

@velvetzhero
Copy link

Quite a pity it wasn't merged yet...

@kadambkaluskar
Copy link

Any update on this?

@leosannlsn
Copy link

Does merging this PR mean that batch/v1beta1 cron jobs will not be supported anymore?

@Freydal Freydal closed this by deleting the head repository Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues listing namespace with cronjobs happening on k8s v1.21.4
7 participants