Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pub access modifier to publicly used struct fields #200

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Add pub access modifier to publicly used struct fields #200

merged 2 commits into from
Apr 8, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 5, 2024 •
edited by coderabbitai bot
Loading

Required for: vlang/v#21183

Summary by CodeRabbit

  • Refactor
    • Enhanced accessibility of various structures by making them publicly accessible.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 5, 2024 •
edited
Loading

Walkthrough

The recent update introduces a significant enhancement across various modules by adding the pub visibility specifier to struct declarations. This adjustment ensures that these structures are now publicly accessible, promoting a more open and interoperable codebase. The change spans multiple areas, including functionality, iteration mechanisms, plotting capabilities, root-finding algorithms, and utility components, reflecting a broad and impactful improvement in the code's accessibility and modularity.

Changes

Files Change Summary
func/func.v Added pub visibility specifier to the struct declarations
iter/ranges.v, plot/show.v, roots/bisection.v, util/util.v Added pub visibility specifier to specific struct declarations

🐇✨
In the land of code, where the rabbits play,
A change was made, oh what a day!
pub was added, far and wide,
Now our structs, no longer hide.
So hop along, and see the sight,
Our code now open, bright as light.
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 5, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c43c3f1 and 1febf73.
Files selected for processing (5)
  • func/func.v (1 hunks)
  • iter/ranges.v (3 hunks)
  • plot/show.v (1 hunks)
  • roots/bisection.v (1 hunks)
  • util/util.v (1 hunks)
Additional comments not posted (7)
util/util.v (1)

14-14: The change to make RangeStep struct publicly accessible aligns well with the PR's objectives.

func/func.v (1)

16-16: The change to make Fn struct publicly accessible aligns well with the PR's objectives.

roots/bisection.v (1)

24-24: The change to make BisectionParams struct publicly accessible aligns well with the PR's objectives.

plot/show.v (1)

15-15: The change to make PlotConfig struct publicly accessible aligns well with the PR's objectives.

iter/ranges.v (3)

18-18: The change to make IntIterParams struct publicly accessible aligns well with the PR's objectives.

75-75: The change to make FloatIterParams struct publicly accessible aligns well with the PR's objectives.

131-131: The change to make LinearIterParams struct publicly accessible aligns well with the PR's objectives.

coderabbitai[bot]
coderabbitai bot reviewed Apr 5, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c43c3f1 and 965b148.
Files selected for processing (5)
  • func/func.v (2 hunks)
  • iter/ranges.v (3 hunks)
  • plot/show.v (1 hunks)
  • roots/bisection.v (1 hunks)
  • util/util.v (1 hunks)
Files skipped from review as they are similar to previous changes (5)
  • func/func.v
  • iter/ranges.v
  • plot/show.v
  • roots/bisection.v
  • util/util.v

@ttytm ttytm changed the title Set visibility of publicly accessed fields to public Add pub access modifier to publicly used struct fields Apr 7, 2024
@ttytm ttytm merged commit af1abf1 into vlang:main Apr 8, 2024
6 of 9 checks passed
@ttytm ttytm deleted the pub-params branch April 8, 2024 16:37
ulises-jeremias added a commit that referenced this pull request Apr 27, 2024
@ulises-jeremias
Merge branch 'main' of github.com:vlang/vsl into feature/new-lapack
e82bda8 
* 'main' of github.com:vlang/vsl:
  Run CI again
  Add more missing `pub` modifiers to public struct fields
  Add `pub` access modifier to publicly used struct fields (#200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ttytm