Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fun: fix int type edge values consts #190

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fun: fix int type edge values consts #190

merged 1 commit into from
Nov 20, 2023

Conversation

ArtemkaKun
Copy link
Contributor

@ArtemkaKun ArtemkaKun commented Nov 8, 2023

This PR needed to make tests pass in vlang/v#19809

Summary by CodeRabbit

  • Bug Fixes
    • Corrected a variable reference error in the binomial function, enhancing its accuracy and reliability.

Copy link

coderabbitai bot commented Nov 8, 2023

Walkthrough

The change in the codebase is a minor but crucial one. It corrects a potential typo or variable reference error in the uint_binomial function, specifically modifying the max_n variable from math.max_u64 to max_u64.

Changes

File Change Summary
fun/fun.v Corrected a potential typo or variable reference error in the uint_binomial function. The max_n variable was changed from math.max_u64 to max_u64.

Poem

🍂 As autumn leaves gently fall,
A tiny change makes a big call.
From math.max_u64 to max_u64, it's a small hop,
But it's the difference between a code crash and a flawless bop.
🐇 Hopping through the code, fixing as we go,
Making sure the binary tree continues to grow.
On this day in history, the X-ray was found,
Just like our bug, hidden but profound.
So let's celebrate this change, small but bright,
Keeping our code running, from morning till night. 🌙


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7fa7171 and a21a567.
Files selected for processing (1)
  • fun/fun.v (1 hunks)
Files skipped from review due to trivial changes (1)
  • fun/fun.v

@ulises-jeremias ulises-jeremias self-requested a review November 8, 2023 15:56
@ulises-jeremias ulises-jeremias merged commit a435426 into vlang:main Nov 20, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants